From: Andreas Oberritter <obi@linuxtv.org>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
linux-dvb-maintainer@linuxtv.org, Manu Abraham <manu@kromtek.com>,
Emard <emard@softhome.net>,
Marko Kohtala <marko.kohtala@luukku.com>,
Wilson Michaels <wilsonmichaels@earthlink.net>,
Kirk Lapray <kirk_lapray@bigfoot.com>,
Mauro Carvalho Chehab <mchehab@brturbo.com.br>,
video4linux-list@redhat.com,
Takeo Takahashi <takahashi.takeo@renesas.com>,
Ralph Metzler <rjkm@thp.uni-koeln.de>,
Gerd Knorr <kraxel@bytesex.org>, Bill Dirks <bdirks@pacbell.net>,
Wolfgang Scherr <scherr@net4you.at>, Alan Cox <alan@redhat.com>,
Ronald Bultje <rbultje@ronald.bitfreak.net>,
Serguei Miridonov <mirsev@cicese.mx>
Subject: Re: [PATCH 08/14] Big kfree NULL check cleanup - drivers/media
Date: Fri, 14 Oct 2005 23:56:18 +0200 [thread overview]
Message-ID: <1129326978.7184.3.camel@ip6-localhost> (raw)
In-Reply-To: <200510132128.12616.jesper.juhl@gmail.com>
On Thu, 2005-10-13 at 21:28 +0200, Jesper Juhl wrote:
> This is the drivers/media/ part of the big kfree cleanup patch.
>
> Remove pointless checks for NULL prior to calling kfree() in drivers/media/.
>
>
> Sorry about the long Cc: list, but I wanted to make sure I included everyone
> who's code I've changed with this patch.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
> ---
>
[...]
> --- linux-2.6.14-rc4-orig/drivers/media/dvb/frontends/mt312.c 2005-08-29 01:41:01.000000000 +0200
> +++ linux-2.6.14-rc4/drivers/media/dvb/frontends/mt312.c 2005-10-13 10:28:50.000000000 +0200
> @@ -675,8 +675,7 @@ struct dvb_frontend* mt312_attach(const
> return &state->frontend;
>
> error:
> - if (state)
> - kfree(state);
> + kfree(state);
> return NULL;
> }
>
Acked-by: Andreas Oberritter <obi@linuxtv.org>
next prev parent reply other threads:[~2005-10-14 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-13 19:28 [PATCH 08/14] Big kfree NULL check cleanup - drivers/media Jesper Juhl
2005-10-14 17:52 ` Manu Abraham
2005-10-14 21:56 ` Andreas Oberritter [this message]
2005-10-15 3:21 ` Wilson Michaels
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1129326978.7184.3.camel@ip6-localhost \
--to=obi@linuxtv.org \
--cc=akpm@osdl.org \
--cc=alan@redhat.com \
--cc=bdirks@pacbell.net \
--cc=emard@softhome.net \
--cc=jesper.juhl@gmail.com \
--cc=kirk_lapray@bigfoot.com \
--cc=kraxel@bytesex.org \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manu@kromtek.com \
--cc=marko.kohtala@luukku.com \
--cc=mchehab@brturbo.com.br \
--cc=mirsev@cicese.mx \
--cc=rbultje@ronald.bitfreak.net \
--cc=rjkm@thp.uni-koeln.de \
--cc=scherr@net4you.at \
--cc=takahashi.takeo@renesas.com \
--cc=video4linux-list@redhat.com \
--cc=wilsonmichaels@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.