Re: eCryptfs: Request for review

["Charles P. Wright" <cwright@cs.sunysb.edu>]

On Wed, 2005-10-19 at 14:55 -0500, Michael Thompson wrote:
> > > > In ecryptfs_llseek,  If you are adding pages for extra information, you
> > > > need to convert the offset to a lower-level offset, and then convert the
> > > > return back to what user space expects it to be.  You should test fsx on
> > > > your file system, to sort these types of things out.
> > > I believe that this is working, we have run fsx "succesfully" for
> > > 10000 iterations. However, its not a total success because we are
> > > bugging out in fs/buffer.c:1822 BUG_ON(PageWriteback(page));
> > > Will look a bit more closely though.
> > Actually nevermind, you are using generic_file_llseek on your own file
> > instead of passing the operation down.  That should be fine and dandy
> > for files, but I don't know if you are going to have problems with
> > directories.
> Guess I'll have to test a bit more then... *marks on the TODO*.
You should check to see which file systems implement llseek for
directories, that should give you a hint as to where you need to do some
testing.

> Would you like to take a stab at why we are hitting the
> fs/buffer.c:1822 BUG_ON(PageWriteback(page)); problem?
> I'm pretty much at a loss, although, I will be honest, I haven't
> looked into it very much
> (it's scary).
I can't be of much help here.

Charles