From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D9AEE1CDFBF; Tue, 22 Oct 2024 22:58:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729637892; cv=none; b=O90BZpDKkKheLmniRZz+iN/rp1ArzFWuih7Vf/pCG2xJ30q23MvtGBJ6SqFiW/eLt5lk9XBLgp7LLuh8Ghr3tJ7rpFP9OHhf1Wa+QuCkm48kjZkVS8cp+zWn5a8pSa5fleh9O2JLEQzigusNdbeKBIq+d28QwL1pcg6Bt8xYOY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729637892; c=relaxed/simple; bh=AOaeQ/JIrGG6hVU/F59SW5zbpMK6YqCThcfIwLGdMu4=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=OGpZykFtqDiSSBoBxtDGtlgkWqsNvXrvxeGtwKX+2gplmaKIlCkzRKr3C4fgArTBICUOjlcClpTkqlOpfRIUEAnFYNqayBFXf9nwSqzjD+MGAfPAJtHfdPf7XUE46RftOfSs2YNZ08szpyUu7UM582pROpWLSYJIimBiuEpI1wo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=src16h4f; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="src16h4f" Received: from [100.65.66.184] (unknown [20.236.11.29]) by linux.microsoft.com (Postfix) with ESMTPSA id 2A8FD21112EF; Tue, 22 Oct 2024 15:58:10 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2A8FD21112EF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1729637890; bh=2QQm/IH+Y8dbs5DxBwqLr/A9c7L7ikg8eZ/If3zOwmI=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=src16h4fKcPufvHf+a4/l9zZ598jjOFJ+msduFTYVgo4IXECIVmFkRq1J6yOBqitr hPkTw/IEMSIeAARlAq2FdLc1xCrvW61+Cuz/aGfzkFzDNamus0jqijwp6NycfalL8z 0ltBw+9TKmhBgiDbUJBGih/Gna5t8d3/QDnJMYYQ= Message-ID: <112aed61-2c4d-450e-9a44-cba33e2a017f@linux.microsoft.com> Date: Tue, 22 Oct 2024 15:58:10 -0700 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: eahariha@linux.microsoft.com, Naman Jain , Michael Kelley Subject: Re: [PATCH 1/2] jiffies: Define secs_to_jiffies() To: lkp@intel.com, Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Thomas Gleixner , Anna-Maria Behnsen , Geert Uytterhoeven , open list , "open list:BLUETOOTH SUBSYSTEM" , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Linux-HyperV References: <20241022185353.2080021-1-eahariha@linux.microsoft.com> Content-Language: en-US From: Easwar Hariharan In-Reply-To: <20241022185353.2080021-1-eahariha@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/22/2024 11:53 AM, Easwar Hariharan wrote: > There are ~500 usages of msecs_to_jiffies() that either use a multiplier > value of 1000 or equivalently MSEC_PER_SEC. Define secs_to_jiffies() to > allow such code to be less clunky. > > Suggested-by: Michael Kelley > Signed-off-by: Easwar Hariharan > --- > include/linux/jiffies.h | 2 ++ > net/bluetooth/hci_event.c | 2 -- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h > index 1220f0fbe5bf..50dba516fd2f 100644 > --- a/include/linux/jiffies.h > +++ b/include/linux/jiffies.h > @@ -526,6 +526,8 @@ static __always_inline unsigned long msecs_to_jiffies(const unsigned int m) > } > } > > +#define secs_to_jiffies(_secs) msecs_to_jiffies((_secs) * MSEC_PER_SEC) > + > extern unsigned long __usecs_to_jiffies(const unsigned int u); > #if !(USEC_PER_SEC % HZ) > static inline unsigned long _usecs_to_jiffies(const unsigned int u) > diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c > index 0bbad90ddd6f..7b35c58bbbeb 100644 > --- a/net/bluetooth/hci_event.c > +++ b/net/bluetooth/hci_event.c > @@ -42,8 +42,6 @@ > #define ZERO_KEY "\x00\x00\x00\x00\x00\x00\x00\x00" \ > "\x00\x00\x00\x00\x00\x00\x00\x00" > > -#define secs_to_jiffies(_secs) msecs_to_jiffies((_secs) * 1000) > - > /* Handle HCI Event packets */ > > static void *hci_ev_skb_pull(struct hci_dev *hdev, struct sk_buff *skb, Sorry, I should have combined distribution lists for the two patches, so everyone received both patches. Combining the lists with this email. Here's the lore link for the series: https://lore.kernel.org/all/20241022185353.2080021-1-eahariha@linux.microsoft.com/ Thanks, Easwar