All of lore.kernel.org
 help / color / mirror / Atom feed
From: dann frazier <dannf@hp.com>
To: netfilter-devel@lists.netfilter.org
Cc: 336431@bugs.debian.org
Subject: Bug#336431: [PATCH] fix ip_conntrack_helper_pptp build when CONFIG_IP_NF_NAT_NEEDED=n
Date: Mon, 31 Oct 2005 18:13:55 -0700	[thread overview]
Message-ID: <1130807635.6630.13.camel@localhost> (raw)

As reported in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=336431,
ip_conntrack_helper_pptp in 2.6.14 fails to build if
CONFIG_IP_NF_NAT_NEEDED isn't enabled.  This patch fixes this by
disabling manipulation of the dir field of ip_conntrack_expect
structures when full nat isn't configured.  Compile tested only.

Signed-off-by: dann frazier <dannf@hp.com>

--- linux-source-2.6.14/net/ipv4/netfilter/ip_conntrack_helper_pptp.c.orig	2005-10-27 18:02:08.000000000 -0600
+++ linux-source-2.6.14/net/ipv4/netfilter/ip_conntrack_helper_pptp.c	2005-10-31 18:12:03.000000000 -0700
@@ -270,13 +270,14 @@
 	exp_orig->expectfn = pptp_expectfn;
 	exp_orig->flags = 0;
 
-	exp_orig->dir = IP_CT_DIR_ORIGINAL;
-
 	/* both expectations are identical apart from tuple */
 	memcpy(exp_reply, exp_orig, sizeof(*exp_reply));
 	memcpy(&exp_reply->tuple, &exp_tuples[1], sizeof(exp_reply->tuple));
 
+#ifdef CONFIG_IP_NF_NAT_NEEDED
+	exp_orig->dir = IP_CT_DIR_ORIGINAL;
 	exp_reply->dir = !exp_orig->dir;
+#endif
 
 	if (ip_nat_pptp_hook_exp_gre)
 		ret = ip_nat_pptp_hook_exp_gre(exp_orig, exp_reply);

-- 
dann frazier <dannf@hp.com>

             reply	other threads:[~2005-11-01  1:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-01  1:13 dann frazier [this message]
2005-11-03  9:54 ` [PATCH] fix ip_conntrack_helper_pptp build when CONFIG_IP_NF_NAT_NEEDED=n Harald Welte
2005-11-03 16:29   ` Bug#336431: " dann frazier
2005-11-03 17:46     ` Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1130807635.6630.13.camel@localhost \
    --to=dannf@hp.com \
    --cc=336431@bugs.debian.org \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.