From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [Bluez-devel] [PATCH] dbus.c cleanup From: Marcel Holtmann To: bluez-devel@lists.sourceforge.net In-Reply-To: References: <20051029175338.GA26114@localhost.localdomain> <1130609278.5396.48.camel@blade> <20051029184820.GA26657@localhost.localdomain> <1130612847.5396.51.camel@blade> <1130760726.17124.17.camel@blade> <1130850674.31561.65.camel@blade> Content-Type: text/plain Message-Id: <1130875099.5048.17.camel@blade> Mime-Version: 1.0 Sender: bluez-devel-admin@lists.sourceforge.net Errors-To: bluez-devel-admin@lists.sourceforge.net Reply-To: bluez-devel@lists.sourceforge.net List-Unsubscribe: , List-Id: BlueZ development List-Post: List-Help: List-Subscribe: , List-Archive: Date: Tue, 01 Nov 2005 20:58:19 +0100 Hi Claudio, > here is patch to move the find_conn function to lib.c file. I just realized that I already moved it out of dbus.c and so lets keep it in hcid as inline function for now. > Regarding the error related functions, can I move to a error.c file or > it's better keep them in the dbus.c? At the moment, I think it is better to keep them there. I don't have any real opinion at the moment and so it might be better not to move to much code around. > Another point is the Disconnect signal. Which approach you preffer > exit or create a timer to re-connect each x seconds? We should try to re-connect. The security is still running and so we can't exit. > IMHO, I think it not necessary handle this scenario. Restart the > dbus-daemon is not common. Every time you update your D-Bus installation. The Ubuntu guys even popup a message box that you should reboot your system ;) Regards Marcel ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel