From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH] skeleton frontend/backend examples and a deadlock Date: Thu, 03 Nov 2005 12:23:25 +1100 Message-ID: <1130981006.8734.2.camel@localhost.localdomain> References: <1130908964.18258.25.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Mark Ryden Cc: Xen Mailing List List-Id: xen-devel@lists.xenproject.org On Wed, 2005-11-02 at 14:52 +0200, Mark Ryden wrote: > Hello, > One little thing: > If I am not wrong, xenbus_register_backend() is > not exported, and it seems to me that we > should have EXPORT_SYMBOL(xenbus_register_backend) so > it will build. Indeed, the backend cannot be built as a module because this, and the vma functions are not exported. The latter can be solved by providing a nice grant-id -> mapped page function in the core I think (and the unmap function) Also, the skeleton was written against a tree where registering a watch did not always call the callback immediately. Now this has been fixed, those explicit calls are removed. Rusty. -- A bad analogy is like a leaky screwdriver -- Richard Braakman