From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Tal Shnaiderman <talshn@mellanox.com>,
Ranjit Menon <ranjit.menon@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] eal/windows: detect insufficient privileges for hugepages
Date: Fri, 10 Jul 2020 23:25:13 +0200 [thread overview]
Message-ID: <11310226.gcHsNcSAOl@thomas> (raw)
In-Reply-To: <8b219c6c-7ad2-6987-ce59-13316bc7c223@intel.com>
09/07/2020 00:27, Ranjit Menon:
> On 7/8/2020 2:48 PM, Dmitry Kozlyuk wrote:
> > AdjustTokenPrivileges() succeeds even if no requested privileges have
> > been granted; this behavior is documented. Check last error code in
> > addition to return value to detect such case.
> >
> > Make error messages more specific and add troubleshooting hint.
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
[...]
> > if (hugepage_claim_privilege() < 0) {
> > - RTE_LOG(ERR, EAL, "Cannot claim hugepage privilege\n");
> > + RTE_LOG(ERR, EAL, "Cannot claim hugepage privilege\n"
> > + "Verify that large-page support privilege "
> > + "is assigned to the current user\n");
The error message can be searched in the code,
so it is better not to break lines.
> Acked-by: Ranjit Menon <ranjit.menon@intel.com>
Applied with merged log lines, thanks.
prev parent reply other threads:[~2020-07-10 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 20:22 [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges for hugepages Dmitry Kozlyuk
2020-07-07 23:45 ` Ranjit Menon
2020-07-08 0:20 ` Dmitry Kozlyuk
2020-07-08 6:43 ` Tal Shnaiderman
2020-07-08 7:49 ` Dmitry Kozlyuk
2020-07-08 21:48 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
2020-07-08 22:27 ` Ranjit Menon
2020-07-10 21:25 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11310226.gcHsNcSAOl@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.