From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Posssible bug in kernel/irq/handle.c
Date: Wed, 09 Nov 2005 13:16:54 +1100 [thread overview]
Message-ID: <1131502615.24637.30.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.64.0511081802160.3247@g5.osdl.org>
> Be vewy vewy caweful when changing that code, though. If you end up with a
> patch, please try to give it some nice stress-testing (both on ppc and
> x86), and then post it for comments, ok? Maybe the arch mailing list and
> Ingo (who else has touched that logic?)
Ok, I'll try to avoid touching that code. In a perfect world, we should
have proper handlers for those firmware interrupts anyway, it's just
that the "spec" says we should call the firmware for any interrupt we
don't handle...
I suppose it should be enough for us to test for desc->action before
calling __do_IRQ() and eventually do the firmware trick then, since I
doubt that if it matters at all, it will happen on shared interrupts...
Ben.
prev parent reply other threads:[~2005-11-09 2:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-09 0:38 Posssible bug in kernel/irq/handle.c Benjamin Herrenschmidt
2005-11-09 1:04 ` Linus Torvalds
2005-11-09 1:50 ` Benjamin Herrenschmidt
2005-11-09 2:07 ` Linus Torvalds
2005-11-09 2:16 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131502615.24637.30.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.