From: "Christopher J. PeBenito" <cpebenito@tresys.com>
To: Johan Fischer <jfischer@cmcrc.com>
Cc: SELinux@tycho.nsa.gov
Subject: Re: [refpolicy][PATCH] fix Makefile BASE_MODS and MOD_MODS detection
Date: Wed, 09 Nov 2005 09:22:36 -0500 [thread overview]
Message-ID: <1131546156.24234.58.camel@sgc> (raw)
In-Reply-To: <43715253.2070108@cmcrc.com>
On Wed, 2005-11-09 at 12:35 +1100, Johan Fischer wrote:
> quick patch to fix the modules detection from the modules.conf file...
>
> before:
> $ awk '/^[[:blank:]]*[[:alpha:]]/{ if ($3 == "module") print $1 }'
> policy/modules.conf
> (no result)
>
> after:
> $ awk '/^[[:blank:]]*[[:alpha:]]*/{ if ($3 == "module") print $1 }'
> policy/modules.conf
> apm
> apache
> bluetooth
I can't reproduce this behavior. I don't believe this patch is correct,
as it makes the regex too inspecific. With the change, the regex
matches all lines, so if the second word in a comment was "module", it
would print out "#", causing errors.
--
Chris PeBenito
Tresys Technology, LLC
(410) 290-1411 x150
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2005-11-09 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-09 1:35 [refpolicy][PATCH] fix Makefile BASE_MODS and MOD_MODS detection Johan Fischer
2005-11-09 14:22 ` Christopher J. PeBenito [this message]
2005-11-25 0:11 ` Johan Fischer
2005-11-25 14:22 ` Christopher J. PeBenito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131546156.24234.58.camel@sgc \
--to=cpebenito@tresys.com \
--cc=SELinux@tycho.nsa.gov \
--cc=jfischer@cmcrc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.