From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [Bluez-devel] [PATCH] dbus.c: use hci_send_req for periodic inquiry commands From: Marcel Holtmann To: bluez-devel@lists.sourceforge.net In-Reply-To: <20051109121639.GA19566@localhost.localdomain> References: <20051109121639.GA19566@localhost.localdomain> Content-Type: text/plain Message-Id: <1131551054.5544.102.camel@blade> Mime-Version: 1.0 Sender: bluez-devel-admin@lists.sourceforge.net Errors-To: bluez-devel-admin@lists.sourceforge.net Reply-To: bluez-devel@lists.sourceforge.net List-Unsubscribe: , List-Id: BlueZ development List-Post: List-Help: List-Subscribe: , List-Archive: Date: Wed, 09 Nov 2005 16:44:14 +0100 Hi Johan, > Here's a patch for the following changes: I applied the patch, but I have some small general comments. Use "0x%02x" or "0x%04x" if you need to display a value in hex in any kind of message. Include the errno clear text value in an error message, because they might be different on different architectures. Regards Marcel ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel