Re: [Bluez-devel] Re: [DBUS PATCH] Disconnect

[Marcel Holtmann <marcel@holtmann.org>]

Hi Claudio,

> If the first "disconnect" patch is not integrated yet, please ignore
> it. It was missing close the HCI socket :)  and I changed some code
> style.

please redo this patch, because I am not fully happy with it. The
DBUS_RECONNECT_TIME should be defined (5 * 1000 * 1000) to make it easy
for people to change it. The compile will optimize this away anyhow.

Please don't change any error messages to repeat the function name. This
is not helpful if you are really looking for problems. Using grep inside
the source to find a error message is really helpful.

Can't reconnect_timer_handler() and reconnect_timer_start() be static?

Check your whitespace. There is no need to have useless whitespaces at
the end of a line. If an if-statement is over multiple lines we still
use tabes and we are not trying to align it with anything of the line
above. In fact we use two tabs to indent more then the actual code
inside the statement. See the rest of the file for examples.

Regards

Marcel




-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel