From: Christophe Varoqui <christophe.varoqui@free.fr>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH] multipath-tools: multipathd makes offline devices active
Date: Sat, 12 Nov 2005 01:12:10 +0100 [thread overview]
Message-ID: <1131754330.7463.104.camel@zezette> (raw)
In-Reply-To: <20051111.184322.71083111.k-ueda@ct.jp.nec.com>
On ven, 2005-11-11 at 18:43 -0500, Kiyoshi Ueda wrote:
> Hi Christophe,
>
> multipathd(8) continues calling reinstate_path() in checkerloop(),
> if multipathd(8) is started on the system which has multipath maps
> including offline devices.
> The reason is pp->checkfn() returns -1 for offline devices and
> pp->state of these paths are 1.
> (I'm using "echo offline > /sys/block/sd?/device/state" for the testing.)
>
> As a result, multipathd(8) makes offline devices active state.
> And this behavior also affects the no_path_retry feature, since
> struct multipath.nr_active is incremented in reinstate_path().
>
> The following patch fixes this problem.
> If the return value from pp->checkfn is -1, the path isn't available.
> So I think that we can ignore it.
>
Looks correct, indeed.
Thanks, applied.
Regards,
cvaroqui
prev parent reply other threads:[~2005-11-12 0:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-11 23:43 [PATCH] multipath-tools: multipathd makes offline devices active Kiyoshi Ueda
2005-11-12 0:12 ` Christophe Varoqui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131754330.7463.104.camel@zezette \
--to=christophe.varoqui@free.fr \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.