From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id AFF1568746 for ; Sun, 13 Nov 2005 09:34:48 +1100 (EST) From: Benjamin Herrenschmidt To: Adrian Bunk In-Reply-To: <20051112222045.GC21448@stusta.de> References: <200511122237.17157.mbuesch@freenet.de> <20051112215304.GB21448@stusta.de> <200511122257.05552.mbuesch@freenet.de> <20051112222045.GC21448@stusta.de> Content-Type: text/plain Date: Sun, 13 Nov 2005 09:31:06 +1100 Message-Id: <1131834667.7406.49.camel@gaston> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, Linus Torvalds , Michael Buesch , Linux Kernel Mailing List Subject: Re: Linuv 2.6.15-rc1 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > ucSystemType is a variable that is EXPORT_SYMBOL'ed but never used in > any way. > > _prep_type is a variable that is needlessly EXPORT_SYMBOL'ed. Therse are old PREP stuffs > But prep_init points to the real problem: > > CONFIG_PPC_PREP requires code from arch/ppc/platforms/, but this > directory is never visited. > > What is the correct fix? > Migrate the code from arch/ppc/platforms/ to arch/powerpc/platforms/ ? Yes, PREP need to be migrated, but that includes adding some minimum device-tree support for it among others. And few people still have PREP machines, I'm not even sure we have access to one here in ozlabs... I think for 2.6.15, we'd better just disable it in .config for ARCH=powerpc. Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964865AbVKLWhD (ORCPT ); Sat, 12 Nov 2005 17:37:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964871AbVKLWhD (ORCPT ); Sat, 12 Nov 2005 17:37:03 -0500 Received: from gate.crashing.org ([63.228.1.57]:16089 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S964865AbVKLWhA (ORCPT ); Sat, 12 Nov 2005 17:37:00 -0500 Subject: Re: Linuv 2.6.15-rc1 From: Benjamin Herrenschmidt To: Adrian Bunk Cc: Michael Buesch , Linus Torvalds , Paul Mackerras , linuxppc-dev@ozlabs.org, Linux Kernel Mailing List In-Reply-To: <20051112222045.GC21448@stusta.de> References: <200511122237.17157.mbuesch@freenet.de> <20051112215304.GB21448@stusta.de> <200511122257.05552.mbuesch@freenet.de> <20051112222045.GC21448@stusta.de> Content-Type: text/plain Date: Sun, 13 Nov 2005 09:31:06 +1100 Message-Id: <1131834667.7406.49.camel@gaston> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > ucSystemType is a variable that is EXPORT_SYMBOL'ed but never used in > any way. > > _prep_type is a variable that is needlessly EXPORT_SYMBOL'ed. Therse are old PREP stuffs > But prep_init points to the real problem: > > CONFIG_PPC_PREP requires code from arch/ppc/platforms/, but this > directory is never visited. > > What is the correct fix? > Migrate the code from arch/ppc/platforms/ to arch/powerpc/platforms/ ? Yes, PREP need to be migrated, but that includes adding some minimum device-tree support for it among others. And few people still have PREP machines, I'm not even sure we have access to one here in ozlabs... I think for 2.6.15, we'd better just disable it in .config for ARCH=powerpc. Ben.