All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: dhowells@redhat.com, Jarkko Sakkinen <jarkko@kernel.org>,
	keyrings@vger.kernel.org, Lukas Wunner <lukas@wunner.de>,
	Ignat Korchagin <ignat@cloudflare.com>,
	"David S. Miller" <davem@davemloft.net>,
	Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	Paul Moore <paul@paul-moore.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	Mimi Zohar <zohar@linux.ibm.com>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org
Subject: Re: [PATCH] KEYS: Invert FINAL_PUT bit
Date: Sun, 04 May 2025 08:44:13 +0100	[thread overview]
Message-ID: <1131866.1746344653@warthog.procyon.org.uk> (raw)
In-Reply-To: <aBb833yQFY5EpEFx@gondor.apana.org.au>

Herbert Xu <herbert@gondor.apana.org.au> wrote:

> +	key->flags |= KEY_FLAG_DONT_GC_YET;

You need __set_bit() or 1<<N.

Also, don't really like the name, but that's just bikeshedding.  I think I'd
lean more to your initial suggestion of KEY_FLAG_ALIVE.

David


  reply	other threads:[~2025-05-04  7:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30 15:25 [PATCH] KEYS: Reduce smp_mb() calls in key_put() Jarkko Sakkinen
2025-05-03 14:39 ` Jarkko Sakkinen
2025-05-03 15:02   ` Herbert Xu
2025-05-04 16:55     ` Jarkko Sakkinen
2025-05-03 22:19   ` David Howells
2025-05-04  0:35     ` Herbert Xu
2025-05-04  5:36       ` [PATCH] KEYS: Invert FINAL_PUT bit Herbert Xu
2025-05-04  7:44         ` David Howells [this message]
2025-05-04  7:52           ` [v2 PATCH] " Herbert Xu
2025-05-09  9:34             ` kernel test robot
2025-05-09  9:45               ` [v3 " Herbert Xu
2025-05-12  9:19                 ` David Howells
2025-05-12 11:42                   ` Jarkko Sakkinen
2025-05-12 12:01                     ` David Howells
2025-05-12 12:07                       ` Herbert Xu
2025-05-04 16:42     ` [PATCH] KEYS: Reduce smp_mb() calls in key_put() Jarkko Sakkinen
  -- strict thread matches above, loose matches on Subject: below --
2025-05-28 12:18 [PATCH] KEYS: Invert FINAL_PUT bit David Howells
2025-06-11  0:22 ` Paul Moore
2025-06-11  9:12   ` Herbert Xu
2025-06-11 15:54     ` Paul Moore
2025-06-11 16:47   ` Jarkko Sakkinen
2025-06-11 17:50   ` Linus Torvalds
2025-06-11 18:45     ` David Howells
2025-06-11 18:59       ` Linus Torvalds
2025-06-11 20:38         ` Al Viro
2025-06-11 21:21           ` Linus Torvalds
2025-06-12 10:32     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1131866.1746344653@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=ignat@cloudflare.com \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=paul@paul-moore.com \
    --cc=peterhuewe@gmx.de \
    --cc=serge@hallyn.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.