From: Tomasz Figa <t.figa@samsung.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>,
'Kukjin Kim' <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: SAMSUNG: Remove unused s5p_device_ehci
Date: Thu, 10 Oct 2013 07:17:50 +0200 [thread overview]
Message-ID: <11324918.I3J8AgutaD@amdn883> (raw)
In-Reply-To: <000501cec562$11209d20$3361d760$%han@samsung.com>
Hi Jingoo,
On Thursday 10 of October 2013 11:40:22 Jingoo Han wrote:
> On Thursday, October 10, 2013 11:26 AM, Sylwester Nawrocki wrote:
> > On 10/10/2013 11:02 AM, Jingoo Han wrote:
> > > Since commit ca91435 "ARM: EXYNOS: Remove unused board files",
> > > s5p_device_ehci is not used anymore. Thus, s5p_device_ehci can
> > > be removed. Also, unnecessary S5P_DEV_USB_EHCI option is removed.
> > >
> > > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> >
> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> >
> > > diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> > > index 8ce0ac0..25f40c9 100644
> > > --- a/arch/arm/plat-samsung/devs.c
> > > +++ b/arch/arm/plat-samsung/devs.c
> > > @@ -49,7 +49,6 @@
> > >
> > > #include <plat/devs.h>
> > > #include <plat/adc.h>
> > > #include <linux/platform_data/ata-samsung_cf.h>
> > >
> > > -#include <linux/platform_data/usb-ehci-s5p.h>
> >
> > Are you planning to remove also this file altogether ? Probably the
> > s5p-ehci driver could be cleaned up then and the platform_data handling
> > dropped from it as a follow up.
>
> Hi Sylwester Nawrocki,
>
> I will rename s5p-ehci to s5p-exynos, then drop platform_data handling
> from it. These will be separate patches.
> Thank you your comment. :-)
I'd recommend keeping driver name as is. S5PV210 is going to receive DT
support soon and it will be also able to use this driver.
Otherwise this looks fine.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-10-10 5:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 2:02 [PATCH] ARM: SAMSUNG: Remove unused s5p_device_ehci Jingoo Han
2013-10-10 2:25 ` Sylwester Nawrocki
2013-10-10 2:40 ` Jingoo Han
2013-10-10 5:17 ` Tomasz Figa [this message]
2013-10-10 5:29 ` Jingoo Han
2013-10-10 5:40 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11324918.I3J8AgutaD@amdn883 \
--to=t.figa@samsung.com \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.