From mboxrd@z Thu Jan 1 00:00:00 1970 From: harry Subject: Re: USB virt 2.6 split driver patch series Date: Mon, 21 Nov 2005 14:01:01 +0000 Message-ID: <1132581661.31295.134.camel@localhost.localdomain> References: <1132579104.31295.110.camel@localhost.localdomain> <20051121134940.GA25045@snarc.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20051121134940.GA25045@snarc.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Vincent Hanquez Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Mon, 2005-11-21 at 14:49 +0100, Vincent Hanquez wrote: > On Mon, Nov 21, 2005 at 01:18:24PM +0000, harry wrote: > > o - I've reformatted all the code to the kernel coding style using > > Lindent and not attempted to improve it after that. Some of the > > formatting needs to be improved. > > some ? this is totally _not_ linux kernel coding style. > please have a look at Documentation/CodingStyle and kill anonymous > inline functions (braces in middle of functions). > I have read Documentation/CodingStyle quite carefully and there is no mention of using braces inside functions. I'm used to using braces to define minimal scopes for local variables which makes the code easier to read by minimising the number of variables you need to keep track of when reading it and by declaring variables closer to where they are used so it is easier to verify that they have been correctly initialised. Is this really banned? Harry.