From mboxrd@z Thu Jan 1 00:00:00 1970 From: harry Subject: Re: USB virt 2.6 split driver patch series Date: Mon, 21 Nov 2005 15:34:47 +0000 Message-ID: <1132587287.31295.151.camel@localhost.localdomain> References: <1132579104.31295.110.camel@localhost.localdomain> <20051121134940.GA25045@snarc.org> <1132581661.31295.134.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Vincent Hanquez List-Id: xen-devel@lists.xenproject.org On Mon, 2005-11-21 at 17:26 +0000, Oleg Goldshmidt wrote: > Another style comment that I have is that I think that > > struct xenidc_channel_struct { > void (*submit_message) > (xenidc_channel * channel, xenidc_channel_message * message); > > is inferior to > > struct xenidc_channel_struct { > void (*submit_message)(xenidc_channel * channel, > xenidc_channel_message * message); > > in terms of readability. Thanks. Yes, I agree. I left it the way that Lindent formatted it but I will do it this way on the manual formatting pass.