From mboxrd@z Thu Jan  1 00:00:00 1970
From: Harry Butterworth <harry@hebutterworth.freeserve.co.uk>
Subject: Re: [PATCH][3/17] USB virt 2.6 split driver---xenidc
	buffer references
Date: Mon, 21 Nov 2005 21:34:54 +0000
Message-ID: <1132608894.4739.27.camel@localhost>
References: <1132579128.31295.114.camel@localhost.localdomain>
	<20051121203136.GC22728@granada.merseine.nu>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20051121203136.GC22728@granada.merseine.nu>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Muli Ben-Yehuda <mulix@mulix.org>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Mon, 2005-11-21 at 22:31 +0200, Muli Ben-Yehuda wrote:
> On Mon, Nov 21, 2005 at 01:18:48PM +0000, harry wrote:
> 
> > +#ifdef MIN
> > +#undef MIN
> > +#endif
> > +
> > +#define MIN( X, Y ) ( ( (X) < (Y) ) ? (X) : (Y) )
> 
> Linux has a much better definition.

So it does. Didn't manage to find it last time.

> 
> > +		memset(buffer, 0, 64);
> 
> s/64/sizeof(buffer)/? (there are arguments either way)
> 
> > +xenidc_buffer_type xenidc_local_buffer_reference_register_buffer_concrete_class
> > +    (xenidc_buffer_concrete_class * class, void (*copy_in_or_out)
> > +      (xenidc_buffer_concrete_class * class,
> > +       xenidc_local_buffer_reference * lbr,
> > +       void *buffer, xenidc_buffer_byte_count byte_count, int out), void (*zero)
> > +      (xenidc_buffer_concrete_class * class,
> > +       xenidc_local_buffer_reference * lbr), int (*calculate_rbr_resources)
> > +      (xenidc_buffer_concrete_class * class,
> > +       xenidc_local_buffer_reference * lbr,
> > +       xenidc_address * address,
> > +       xenidc_buffer_resource_list * list),
> > +     xenidc_buffer_concrete_class ** (*create_rbr)
> > +      (xenidc_buffer_concrete_class * class,
> > +       xenidc_local_buffer_reference * lbr,
> > +       xenidc_address * address,
> > +       xenidc_buffer_resource_provider * provider,
> > +       xenidc_remote_buffer_reference * rbr,
> > +       int access_flags), void (*revoke_rbr)
> > +      (xenidc_buffer_concrete_class ** context, xenidc_callback * callback)
> > +    ) {
> 
> I guess this is one case where typedefs would improve the code ;-)

This looked much neater before Lindent got hold of it.

> 
> > +	if (zero == NULL) {
> > +		zero = xenidc_local_buffer_reference_default_zero;
> > +	}
> 
> no braces please
OK
> 
> Cheers,
> Muli
-- 
Harry Butterworth <harry@hebutterworth.freeserve.co.uk>