From: Fernando Luis Vazquez Cao <fernando@intellilink.co.jp>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-kernel@vger.kernel.org, fastboot@lists.osdl.org
Subject: [PATCH 3/4] stack overflow safe kdump (i386) - do_nmi
Date: Tue, 29 Nov 2005 03:00:57 +0900 [thread overview]
Message-ID: <1133200858.2425.102.camel@localhost.localdomain> (raw)
crash_nmi_callback is called right after a system crash which might have
caused by stack overflow, thus smp_processor_id should not be trusted.
Use the safe replacement safe_smp_processor_id.
---
diff -urNp linux-2.6.15-rc2/arch/i386/kernel/traps.c
linux-2.6.15-rc2-sov/arch/i386/kernel/traps.c
--- linux-2.6.15-rc2/arch/i386/kernel/traps.c 2005-11-29
01:46:34.000000000 +0900
+++ linux-2.6.15-rc2-sov/arch/i386/kernel/traps.c 2005-11-29
01:52:17.000000000 +0900
@@ -648,7 +648,7 @@ fastcall void do_nmi(struct pt_regs * re
nmi_enter();
- cpu = smp_processor_id();
+ cpu = safe_smp_processor_id();
#ifdef CONFIG_HOTPLUG_CPU
if (!cpu_online(cpu)) {
reply other threads:[~2005-11-28 18:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133200858.2425.102.camel@localhost.localdomain \
--to=fernando@intellilink.co.jp \
--cc=ebiederm@xmission.com \
--cc=fastboot@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.