From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pFtEd-0004qj-7c for mharc-grub-devel@gnu.org; Thu, 12 Jan 2023 03:46:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFtEc-0004qb-IC for grub-devel@gnu.org; Thu, 12 Jan 2023 03:46:54 -0500 Received: from mout.gmx.net ([212.227.17.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFtEa-0006n2-LH for grub-devel@gnu.org; Thu, 12 Jan 2023 03:46:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1673513189; bh=g+wOMj9Eyhz+kRsgFLqzRm2JMp2f3iveQ/thxZLqARw=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=cL9DwAgYdzumCrxo1qsJr6xubfK+w5n4CEKsTNitjBAmSbm+SisankHaSVXN+RACt 1Awzb6Y560T6+4yKHcLBTv8aKQ7xY1Hh6eYs05VxkwHdK67MKFUVmnxQFBOZsgVoEv SnUNNm/rTXBLCeku0DtNfo6l6mzhc281tNQINRJ2vnf3qg3XbTKOfyn1a7kksJyWRr JAPYXBOyxohRbO/EH2lotnnJS3puDtz739i3E3JqC0GfqEeXkc368BKAZRMEicTgsP N+F/ZqWQ/3x2q1dssvJeZVftZZ08G+UGaioeF8oz3AxqTFWt4DrywWVAkslL9leAKG 1OOuoPK+bL53w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from scdbackup.webframe.org ([84.179.236.73]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mj8qj-1oanmi0ZOv-00f7MB; Thu, 12 Jan 2023 09:46:29 +0100 Date: Thu, 12 Jan 2023 09:45:21 +0100 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: Proposal v2: fs/iso9660: Prevent skipping CE or ST at start of continuation area Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: lidong.chen@oracle.com, fengtao40@huawei.com, yanan@huawei.com, daniel.kiper@oracle.com, lichenca2005@gmail.com References: <87CFA906-7363-4690-BC1B-9771F32EACE6@ORACLE.COM> In-Reply-To: <87CFA906-7363-4690-BC1B-9771F32EACE6@ORACLE.COM> Message-Id: <11335387638173384608@scdbackup.webframe.org> X-Provags-ID: V03:K1:+l8dcDzw2+Ml0MBWQuRgJJ1uRcWfevui5LpdUozYFu4TjtBXtUy oUxKym+q2o6Zat4WxXuPnUu9gI72hPEcVMLCdiEx797OmIEeG6WIGZdsZj/qNxN5B4vGUbV MKL3ViDDLhi6T1GdjnZiRKmXc78sY/4/QSF8/80QSzqsCkWnKDtP7LXah8dChowXRa9StI7 i5s5Gq/P6+6jRwdlmdYLg== UI-OutboundReport: notjunk:1;M01:P0:kh3RaDu2w0s=;GUnS9M8zUCWzzYffYr01ARs+2oE 0N9fi3yqsQjzrQFQ+pijJSNdqd6nn3cZeUquQyMbPiDquQL/et6ccFtDWuyO7O+NnikyjVzVK pxhTJG/v80RTYC9s+Pb0NLP7kYtF5vt/t3sjfyoewTHlMIIHSxMZrwB316xslJv7Vc8WcZQ6A 4/hpYcFjM0qBu6VgbwHGrGzA+zVf8OvIy6+d3APnDQycBL1sKP4kwbyvX1r8qD9rlZRmb9ffA Z96C/x48cztXlXevo+FiOfA9DNozDXaYY+gUZ9Yn004ZuYY4k6WliwRCPEgMOaKXI7/F+htgL oqSRVT87eS5lk5L9znUT78QIPk/9M8hFbq7sJSj1ID+LrGCw3/Y427wKYM8drQPQ1xDjRTXdj 3cjUoR8C78jRlsK9War4/9+u0THe1R2uaSn1Atf+q9kiynmymBFFiFf++UFaV8WwhEVTegHmF OAjGJSneg2H6IAWH6yYt6XpjxbYiFSTYacc8pD6EapC4LA1miI6QSQXVKwZSrHFH84Tie11Zo Oab8QnPYcOVlQRsQZpzDc9djbuHRtnDD9nP6KzDTgoz9apqp9hqi0DEyVNm7vow8TWMtcUm9c VWLYpJ7ovhgN3PFbIXjN4bQbX84isSQD8TiaBOUqW/rP3DB/5pEMZnFFxIoOTP0RLP5bSydIn UH8JYBxzlB6+hzYZKKVC0kwsDMOKHMY2ZetrqR14u+pQAy8dXar1aAkfBu+J9Q7qxB8vC1TsS J+F0bTyrr3bL2sq+Vdmzm64oa/7yAsyCdE2csc9DH4PfPD3rKHA3oac8suEMyT4wNRAqj+lZt Mxj04W4hy1HiMLA4heIeSR/GhK8/4F8GGWqxRJ0qftIPIRmOWySJr7Mo7fsYewTaaQH/eyUwg /Ht9xsotGeR5x5q7SxrAISr8+FPNu3BBghURgsDGQWwvf/naQccm/k1W1XbWH8Z6xF0w58woQ qtqOKqFcJrsWNoM5yETM+ROwWiA= Received-SPF: pass client-ip=212.227.17.20; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2023 08:46:54 -0000 Hi, Lidong Chen wrote: > To test it, I am thinking to add the ISO entry in 40_custom script, then= select > the ISO from Grub menu. Is it the right way to test it? Or, is there a b= etter way > to it? I have to leave the answer to the experienced GRUB developers. Testing is my weak spot with GRUB. About 6 weeks ago i tried to demonstrat= e a risk for memory fault and grub-fstest simply did not want to fail. This reminds me that i should have tested my ISOs with grub-fstest before posting them. To my luck the program as pulled 6 weeks ago behaves like i predicted: $ ./grub-fstest ce_loop.iso ls / x $ ./grub-fstest ce_loop2.iso ls / ^C $ I waited about half a minute (on a 4 GHz Xeon) for the second run to end. Then i aborted it by Ctrl+C. As i am at it, i tried with Linux kernel "5.10.0-13-amd64 #1 SMP Debian 5.10.106-1 (2022-03-17)": # mount ce_loop.iso /mnt/iso mount: /mnt/iso: WARNING: source write-protected, mounted read-only. # ls -l /mnt/iso total 0 # No file /x but also no special messages in dmesg. Only: [ ...] loop: module loaded [ ...] ISO 9660 Extensions: RRIP_1991A Same behavior with the ISO which drives grub-fstest into the endless loop: # umount /mnt/iso # mount ce_loop2.iso /mnt/iso mount: /mnt/iso: WARNING: source write-protected, mounted read-only. # ls -l /mnt/iso total 0 # So Linux seems to be safe against this hack. (I will have a look into the source in order to learn how this situation gets handled.) > Thanks a lot for the detail instruction! It is very helpful for the test= as > well as for my learning. That's the topic where i can be of use. Don't hesitate to ask for explanations, pointers to the specs, or nastily manipulated ISOs. Have a nice day :) Thomas