All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shaohua Li <shaohua.li@intel.com>
To: linux-pm@lists.osdl.org
Subject: [RFC] change suspend_finish order slightly
Date: Fri, 02 Dec 2005 19:15:48 -0800	[thread overview]
Message-ID: <1133579748.7835.6.camel@linux.site> (raw)

[-- Attachment #1: Type: text/plain, Size: 967 bytes --]

The BIOS guys here require ACPI _WAK method which is called in
pm_ops->finish is invoked after all CPUs are resumed. Detail info can be
found at http://bugzilla.kernel.org/show_bug.cgi?id=5651. To do this,
this patch tries to change the order slightly. Does this break other
platforms?

Thanks,
Shaohua
---

 linux-2.6.14-root/kernel/power/main.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN kernel/power/main.c~smp_s3_order kernel/power/main.c
--- linux-2.6.14/kernel/power/main.c~smp_s3_order	2005-11-03 14:18:29.000000000 +0800
+++ linux-2.6.14-root/kernel/power/main.c	2005-11-03 14:21:05.000000000 +0800
@@ -133,10 +133,10 @@ static int suspend_enter(suspend_state_t
 static void suspend_finish(suspend_state_t state)
 {
 	device_resume();
-	if (pm_ops && pm_ops->finish)
-		pm_ops->finish(state);
 	thaw_processes();
 	enable_nonboot_cpus();
+	if (pm_ops && pm_ops->finish)
+		pm_ops->finish(state);
 	pm_restore_console();
 }
 
_



[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2005-12-03  3:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-03  3:15 Shaohua Li [this message]
2005-12-02 20:33 ` [RFC] change suspend_finish order slightly Patrick Mochel
2005-12-04 13:55 ` Nigel Cunningham
  -- strict thread matches above, loose matches on Subject: below --
2005-12-05 23:09 Li, Shaohua
2005-12-06  1:36 ` Nigel Cunningham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1133579748.7835.6.camel@linux.site \
    --to=shaohua.li@intel.com \
    --cc=linux-pm@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.