Re: [RFC] Smallscreen mod for GtkFileChooser

[Paul Sokolovsky <pmiscml@gmail.com>]

Hello Florian,

Monday, January 7, 2008, 6:51:34 PM, you wrote:

> Hi,

> Paul Sokolovsky schrieb:
>>   I've prepared a patch to make GtkFileChooser, a
>> contemporary gtk's file open/save widget, to suite small, PDA-like
>> screens (including QVGA) better.

>>   The patch is available at
>> http://bugs.openembedded.org/show_bug.cgi?id=3634 , with extensive
>> description at
>> http://pfalcon-oe.blogspot.com/2008/01/smallscreen-mod-for-gtkfilechooser.html

> Looks pretty good. I like the patch because it is not that intrusive.
> If you could make all changes depend on the screen size it would be worth trying
> to get it upstream. This might save us a lot of work in future.

  As Ross Burton of OpenedHand commented in my blog, they make steps
to upstream their changes, but of course that doesn't go smooth, it
takes time, refactors, waiting for new versions, etc. So, I'd prefer
to leave that to big guys, knowing that they care to make the future
bright. With my little-guy-who-scratches-his-and-fellow-users'-itches
hat on, I care about present being bright too, and sustainability of
the whole Linux-on-PDA effort. So, here's small patch optimized for a
given criteria (size), and I can maintain it in OE for now, even if
eventually it will be replaced by something else. In the meantime, I
have lotsa other patches ready, or in work, and working on them and
their upstreaming would be more beneficial imho.

  (Oh, and if someone has free big-guy-from-the-industry's hat, please
let me know ;-) ).

>> . I'm glad I've written it in high detail, because Koen quickly
>> pointed me to similar patches in Poky:
>> 
>> http://svn.o-hand.com/view/poky?rev=3408&view=rev
>> http://svn.o-hand.com/view/poky?rev=2596&view=rev
>> 
>>   I didn't try them, but they appear to make more invasive changes to
>> gtk+, though apparently add more features (for good, bad, or for
>> vendor's requirements).

> Do we have a screenshot around to see how it looks? :)

  I still didn't try it due to the above. I'd like first a confirmation
from Poky people that merging those patches to OE will be of benefit
to them (for example, wider testing). Then we can review the
functionality. I do worry a bit about QVGA support, as all latest OH
workings seems to be not optimized for it (Sato, Pimlico).

> Greetings

> Florian




-- 
Best regards,
 Paul                            mailto:pmiscml@gmail.com