From: James Bottomley <James.Bottomley@SteelEye.com>
To: Michael Reed <mdr@sgi.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] OOPS due to clearing eh_action prior to aborting eh command
Date: Wed, 07 Dec 2005 18:34:57 -0500 [thread overview]
Message-ID: <1133998497.3898.4.camel@mulgrave> (raw)
In-Reply-To: <43975F24.4040904@sgi.com>
On Wed, 2005-12-07 at 16:16 -0600, Michael Reed wrote:
> FWIW, the situation I'm reporting isn't done after timeout, it's
> the scsi error handler calling the LLDD abort routine, which actually
> aborts the command and completes it. The eh_action is cleared before
> the abort, violating what appears to be the accepted protocol of having
> the LLDD complete aborted commands.
>
> Am I missing something in your comment? (It wouldn't surprise me!)
The timeout race still exists, though. Both fixes would solve both
problems. It would just be easier to follow if the logic of the error
handler done follows that of the normal done function (i.e. don't do
anything after the command times out).
James
next prev parent reply other threads:[~2005-12-07 23:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 21:56 [PATCH] OOPS due to clearing eh_action prior to aborting eh command Michael Reed
2005-12-07 22:06 ` James Bottomley
2005-12-07 22:16 ` Michael Reed
2005-12-07 23:34 ` James Bottomley [this message]
2005-12-08 2:31 ` Michael Reed
2005-12-08 3:46 ` Michael Reed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133998497.3898.4.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mdr@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.