All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: Jody McIntyre <scjody@modernduck.com>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
	linux1394-devel@lists.sourceforge.net,
	Ben Collins <bcollins@debian.org>,
	Andrew de Quincey <adq@lidskialf.net>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sbp2: better check of transfer direction (protects from panic or oops)
Date: Fri, 09 Dec 2005 17:26:36 -0500	[thread overview]
Message-ID: <1134167196.3491.2.camel@mulgrave> (raw)
In-Reply-To: <20051209193423.GB19441@conscoop.ottawa.on.ca>

On Fri, 2005-12-09 at 14:34 -0500, Jody McIntyre wrote:
> I realize that.. The question is "should we rely on the SCSI subsystem
> to set a valid direction, or should we be checking it ourselves?"

You should rely on the SCSI subsystem.  If everyone has their own work
around, a) we get bloated drivers and b) the original bug is never
fixed.

James




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click

  parent reply	other threads:[~2005-12-09 22:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200512082144.jB8Li6Ul022982@einhorn.in-berlin.de>
     [not found] ` <20051209171922.GW19441@conscoop.ottawa.on.ca>
2005-12-09 19:01   ` [PATCH] sbp2: better check of transfer direction (protects from panic or oops) Stefan Richter
2005-12-09 19:34     ` Jody McIntyre
2005-12-09 20:51       ` Stefan Richter
2005-12-09 22:26       ` James Bottomley [this message]
2005-12-10 14:05     ` Stefan Richter
2005-12-10 18:21       ` Christoph Hellwig
2005-12-10 21:46       ` Douglas Gilbert
2005-12-10 23:13         ` Christoph Hellwig
2005-12-10 11:24   ` [PATCH] sbp2: fix panic when ejecting an ipod Stefan Richter
2005-12-10 23:28     ` [stable] " Greg KH
2005-12-11  1:02       ` Stefan Richter
2005-12-14 20:09         ` Stefan Richter
2005-12-14 20:38           ` Greg KH
2005-12-14 22:32             ` [PATCH 2.6.14.3 1/2] SCSI: fix transfer direction in sd (kernel panic when ejecting iPod) Stefan Richter
2005-12-14 22:34               ` [PATCH 2.6.14.3] SCSI: fix transfer direction in scsi_lib and st Stefan Richter
2005-12-14 22:43                 ` Stefan Richter
2005-12-23 19:05                   ` [stable] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1134167196.3491.2.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=adq@lidskialf.net \
    --cc=bcollins@debian.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=scjody@modernduck.com \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.