All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <liam.girdwood@wolfsonmicro.com>
To: James Courtier-Dutton <James@superbug.co.uk>
Cc: alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: [PATCH] Adds dB gain to alsa-driver, alsa-lib.
Date: Thu, 15 Dec 2005 19:32:05 +0000	[thread overview]
Message-ID: <1134675125.3313.23.camel@localhost.localdomain> (raw)
In-Reply-To: <43A1B744.2050703@superbug.co.uk>

On Thu, 2005-12-15 at 18:34 +0000, James Courtier-Dutton wrote:

> 
> The only piece of information reported by the kernel sound driver is a 
> db_scale value.  It is a unsigned int at application layer, but the 
> current IOCTL TLV truncates this to 32bit unsigned int. alsa-lib then 
> uses this value to decide which translation function to apply to the 
> currently available "volume" value.
> I view this "db_scale" value as simply a hint from the low level driver 
> at which conversion function should be used.
> The conversion function in alsa-lib can then be as simple or as 
> complicated as required.
> 

I'm wondering whether it might be a better idea to use the "db_scale" to
store the specifics of the gain rather than just a hint.

IMHO we need to be able to specify:-

 o number of steps in control
 o starting dB setting
 o step size (including negative bit)

This could either be divided up into the 32 bits of db_scale or by
adding another member(s) to the struct.

This would then mean alsa lib doesn't need to know about the dB settings
for each codec/card (as they are quite different) and the dB information
would be in the driver where it belongs.

Liam

 



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click

  parent reply	other threads:[~2005-12-15 19:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-15 18:34 [PATCH] Adds dB gain to alsa-driver, alsa-lib James Courtier-Dutton
2005-12-15 18:58 ` Lee Revell
2005-12-15 19:06   ` James Courtier-Dutton
2005-12-15 19:16     ` Lee Revell
2005-12-15 19:13 ` Jaroslav Kysela
2005-12-15 19:45   ` James Courtier-Dutton
2005-12-16 10:27     ` Takashi Iwai
2005-12-16 10:47       ` James Courtier-Dutton
2005-12-16 12:05         ` Takashi Iwai
2005-12-16 12:14           ` Jaroslav Kysela
2005-12-16 12:43           ` James Courtier-Dutton
2005-12-16 13:27             ` Takashi Iwai
2005-12-16 13:47               ` James Courtier-Dutton
2005-12-16 14:11                 ` Takashi Iwai
2005-12-16 14:11                   ` Jaroslav Kysela
2005-12-16 14:55                     ` Liam Girdwood
2005-12-16 11:09       ` Liam Girdwood
2005-12-16 12:37     ` Jaroslav Kysela
2005-12-16 13:08       ` James Courtier-Dutton
2005-12-16 14:05         ` Jaroslav Kysela
2005-12-16 14:24   ` Takashi Iwai
2005-12-15 19:32 ` Liam Girdwood [this message]
2005-12-15 19:48   ` James Courtier-Dutton
2005-12-16 10:49     ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1134675125.3313.23.camel@localhost.localdomain \
    --to=liam.girdwood@wolfsonmicro.com \
    --cc=James@superbug.co.uk \
    --cc=alsa-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.