From: Eric Sesterhenn / snakebyte <snakebyte@gmx.de>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] check unsigned < 0 in media/video/msp3400.c
Date: Fri, 16 Dec 2005 12:15:04 +0000 [thread overview]
Message-ID: <1134735304.8780.1.camel@alice> (raw)
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
hi,
yet another patch, index is unsigned and used as
an array index, so it should be safe to remove
the comparison.
Signed-of-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.15-rc5-git5/drivers/media/video/msp3400.c.orig 2005-12-16 12:49:17.000000000 +0100
+++ linux-2.6.15-rc5-git5/drivers/media/video/msp3400.c 2005-12-16 12:49:23.000000000 +0100
@@ -2164,7 +2164,7 @@ static int msp_command(struct i2c_client
{
struct v4l2_audioout *a=(struct v4l2_audioout *)arg;
- if (a->index<0||a->index>2)
+ if (a->index>2)
return -EINVAL;
if (a->index==2) {
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2005-12-16 12:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1134735304.8780.1.camel@alice \
--to=snakebyte@gmx.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.