Re: [PATCH 2.6.15-rc6] block: Make CDROMEJECT more robust

[Ben Collins <ben.collins@ubuntu.com>]

On Mon, 2005-12-19 at 21:46 +0100, Jens Axboe wrote:
> On Mon, Dec 19 2005, Ben Collins wrote:
> > > So the medium removal command does require write permission on the
> > > deviec, but it doesn't require root. If they need to rw to the device
> > > fs, surely they need write permissions on the device in the first place?
> > 
> > bcollins@colorless:~$ id -a
> > uid=1000(bcollins) gid=1000(bcollins)
> > groups=4(adm),20(dialout),24(cdrom),25(floppy),29(audio),30(dip),44(video),46(plugdev),104(lpadmin),105(scanner),106(admin),1000(bcollins)
> > bcollins@colorless:~$ ls -l /dev/hdc
> > brw-rw---- 1 root plugdev 22, 0 Dec 19  2005 /dev/hdc
> > bcollins@colorless:~$ eject -s /dev/hdc
> > eject: unable to eject, last error: Operation not permitted
> > bcollins@colorless:~$ eject -r /dev/hdc
> 
> Does eject open the device O_RDWR?

No, it was opening it RDONLY. I changed it to RDWR, and it allowed the
SG_IO commands to work without root. I'll send a patch to eject for
that.

-- 
   Ben Collins <ben.collins@ubuntu.com>
   Developer
   Ubuntu Linux