From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@redhat.com>,
Eric Lemoine <eric.lemoine@gmail.com>
Subject: Re: sungem hangs in atomic if netconsole enabled but no carrier
Date: Wed, 21 Dec 2005 09:59:14 +1100 [thread overview]
Message-ID: <1135119554.10035.114.camel@gaston> (raw)
In-Reply-To: <20051220221906.GB2525@electric-eye.fr.zoreil.com>
On Tue, 2005-12-20 at 23:19 +0100, Francois Romieu wrote:
> net/core/netpoll.c::netpoll_send_skb() notices that the queue is stopped
> and decides to try the usual NAPI poll(). A few function calls later, the
> driver ends in drivers/net/sungem.c::gem_poll() where it takes so many
> (irq-)locks that I do not even want to verify that it has a chance
> to play nice with the pending gem_link_timer().
I'm not fan of the locking in sungem, I think I wrote a big fat comment
about it and why it is like that for now, better ideas are welcome :)
Ben.
prev parent reply other threads:[~2005-12-20 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-20 12:08 sungem hangs in atomic if netconsole enabled but no carrier Johannes Berg
2005-12-20 21:18 ` Benjamin Herrenschmidt
2005-12-20 21:23 ` David S. Miller
2005-12-20 22:19 ` Francois Romieu
2005-12-20 22:59 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1135119554.10035.114.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=davem@redhat.com \
--cc=eric.lemoine@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.