From: Pavel Roskin <proski@gnu.org>
To: Marco Costalba <mcostalba@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: [PATCH] gqit: enable compiler warnings
Date: Tue, 20 Dec 2005 21:11:08 -0500 [thread overview]
Message-ID: <1135131068.1183.6.camel@dv> (raw)
The "-O2" flag should be separated from the threading support. Besides,
it belongs to CCFLAGS (compile flags common to C and C++), not to
CPPFLAGS (preprocessor flags). While at that, enable all warnings by
-Wall, except those about non-virtual destructors, which are "inherited"
from Qt. Portability is not affected since -O2 was already
gcc-specific.
Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/SConstruct b/SConstruct
index 55fd206..b0b5d0f 100644
--- a/SConstruct
+++ b/SConstruct
@@ -27,8 +27,10 @@ env['ENV']['HOME'] = os.environ['HOME']
installDir = env['HOME']+'/bin'
+env.Append( CCFLAGS = ['-O2', '-Wall' ,'-Wno-non-virtual-dtor'] )
+
## Uncomment the following if you need threading support threading
-env.Append( CPPFLAGS = ['-O2', '-DQT_THREAD_SUPPORT', '-D_REENTRANT', '-I/usr/include/qt3'] )
+env.Append( CPPFLAGS = ['-DQT_THREAD_SUPPORT', '-D_REENTRANT', '-I/usr/include/qt3'] )
if os.uname()[0] == "FreeBSD":
env.Append(LINKFLAGS=["-pthread"])
--
Regards,
Pavel Roskin
next reply other threads:[~2005-12-21 2:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-21 2:11 Pavel Roskin [this message]
2005-12-21 7:11 ` [PATCH] gqit: enable compiler warnings Marco Costalba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1135131068.1183.6.camel@dv \
--to=proski@gnu.org \
--cc=git@vger.kernel.org \
--cc=mcostalba@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.