From: Alex Williamson <alex.williamson@hp.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] incorrect return from ia64_pci_legacy_write()
Date: Wed, 21 Dec 2005 22:21:36 +0000 [thread overview]
Message-ID: <1135203696.4180.12.camel@localhost> (raw)
Tony,
Maybe there's time for one more push to Linus? The function
ia64_pci_legacy_write() returns 0 for everything except errors. This
return value gets sent back to the user from pci_write_legacy_io(),
making it look like every write fails. The trivial patch below copies
the behavior of the SGI sn machvec and does what would be expected from
something implementing a write() function. Please apply, Thanks,
Alex
Signed-off-by: Alex Williamson <alex.williamson@hp.com>
---
diff -r 513446906e2e arch/ia64/pci/pci.c
--- a/arch/ia64/pci/pci.c Wed Dec 21 19:05:15 2005
+++ b/arch/ia64/pci/pci.c Wed Dec 21 14:52:44 2005
@@ -700,7 +700,7 @@
*/
int ia64_pci_legacy_write(struct pci_dev *bus, u16 port, u32 val, u8 size)
{
- int ret = 0;
+ int ret = size;
switch (size) {
case 1:
reply other threads:[~2005-12-21 22:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1135203696.4180.12.camel@localhost \
--to=alex.williamson@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.