From: James Bottomley <James.Bottomley@SteelEye.com>
To: David Caldwell <david@porkrind.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [SCSI] Add support for braindead Cypress USB ATA passthrough CDBs
Date: Fri, 23 Dec 2005 09:52:40 -0600 [thread overview]
Message-ID: <1135353160.3728.10.camel@mulgrave> (raw)
In-Reply-To: <20051221122442.GA16571@porkrind.org>
On Wed, 2005-12-21 at 04:24 -0800, David Caldwell wrote:
> This patch does 2 things. It reimplements the SG_FLAG_LUN_INHIBIT flag
> in the SG_IO ioctl which stops the scsi subsystem from overwriting the
> 2nd byte of the CDB with the LUN. It also doesn't guess the CDB length
> when sending the SG_IO ioctl to the sg device (the main scsi_ioctl
> already did this).
>
> This is for the Cypress CY7C68310 USB to ATA bridge chip (and most
> likely other USB to ATA chips from Cypress), which implements an ATA
> passthrough command that is 16 bytes long and starts with the bytes
> 0x24 0x24. (Not vendor unique, weird length for opcode 0x24, and
> misuse of the LUN area all at the same time--Lovely).
I think this approach is too invasive to the stack. When this was
discussed in november, there wasn't much enthusiasm for resurrecting the
long dead LUN_INHIBIT flag. The two suggested mechanisms are
1) Simply don't mangle the LUN for SCSI_UNKNOWN and then have all the
subsystems lying about SCSI_2 compliance instead set their mangled level
to SCSI_UNKNOWN (which seems to be more truthful)
2) If 1) doesn't work, then use a blacklist entry which the subsystems
would also have access to.
James
next prev parent reply other threads:[~2005-12-23 15:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-21 12:24 [SCSI] Add support for braindead Cypress USB ATA passthrough CDBs David Caldwell
2005-12-22 9:24 ` thomas schorpp
2005-12-22 20:22 ` David Caldwell
2005-12-23 15:52 ` James Bottomley [this message]
2005-12-23 17:41 ` Jeff Garzik
2005-12-23 17:59 ` James Bottomley
2005-12-23 19:12 ` David Caldwell
2005-12-23 20:34 ` James Bottomley
2005-12-23 21:13 ` David Caldwell
2005-12-24 3:28 ` Douglas Gilbert
2005-12-24 7:11 ` David Caldwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1135353160.3728.10.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=david@porkrind.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.