All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kristian Mueller <kernel@mput.de>
To: Ben Collins <bcollins@ubuntu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/15] via-pmu: Wrap some uses of sleep_in_progress with proper ifdef's
Date: Thu, 05 Jan 2006 03:34:19 +0800	[thread overview]
Message-ID: <1136403259.14273.17.camel@pismo> (raw)
In-Reply-To: <0ISL00EOC96O6A@a34-mta01.direcway.com>

Hi Ben

On Mi, 2006-01-04 at 17:01 -0500, Ben Collins wrote:
> Basically completes what's already in the rest of the driver.
> sleep_in_progress is only defined for pm+ppc32.
> 
> Signed-off-by: Ben Collins <bcollins@ubuntu.com>

We've already found a different solution to this in the Linuxppc-dev
list.

See:
 http://patchwork.ozlabs.org/linuxppc/patch?id=3737


Fix compilation of via-pmu.c without Power Management support.

Signed-off-by: Kristian Mueller <Kristian-M@Kristian-M.de>
Signed-off-by: Paul Mackerras <paulus@samba.org>

---

--- linux/drivers/macintosh/via-pmu.c.orig2005-12-15 11:28:28.000000000
+0800
+++ linux/drivers/macintosh/via-pmu.c2005-12-15 12:20:43.000000000 +0800
@@ -157,8 +157,8 @@ static int pmu_version;
 static int drop_interrupts;
 #if defined(CONFIG_PM) && defined(CONFIG_PPC32)
 static int option_lid_wakeup = 1;
-static int sleep_in_progress;
 #endif /* CONFIG_PM && CONFIG_PPC32 */
+static int sleep_in_progress;
 static unsigned long async_req_locks;
 static unsigned int pmu_irq_stats[11];



  reply	other threads:[~2006-01-05  3:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-04 22:01 [PATCH 12/15] via-pmu: Wrap some uses of sleep_in_progress with proper ifdef's Ben Collins
2006-01-04 19:34 ` Kristian Mueller [this message]
2006-01-05 14:17   ` Ben Collins
2006-01-05 17:22     ` Kristian Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1136403259.14273.17.camel@pismo \
    --to=kernel@mput.de \
    --cc=bcollins@ubuntu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.