From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Luiz Fernando Capitulino <lcapitulino@mandriva.com.br>
Cc: Arjan van de Ven <arjan@infradead.org>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slab: Adds missing kmalloc() checks.
Date: Sat, 07 Jan 2006 04:12:50 +0200 [thread overview]
Message-ID: <1136599971.7163.3.camel@localhost> (raw)
In-Reply-To: <20060106133051.367f2d9b.lcapitulino@mandriva.com.br>
Hi,
On Fri, 2006-01-06 at 13:12 -0200, Luiz Fernando Capitulino wrote:
> | > Adds two missing kmalloc() checks in kmem_cache_init(). Note that if the
> | > allocation fails, there is nothing to do, so we panic();
On Fri, 06 Jan 2006 16:24:47 +0100
Arjan van de Ven <arjan@infradead.org> wrote:
> | ok so what good does this do? if you die this early.. you are in deeper
> | problems, and can't boot. while this makes the code bigger...
On Fri, 2006-01-06 at 13:30 -0200, Luiz Fernando Capitulino wrote:
> Well, you'll get a panic with a message saying you have no memory to
> boot, instead of a OOPS with a kernel NULL pointer derefecence, which
> will make you look for a bug.
The code is in init section so I don't think size is an issue. A plain
BUG_ON would be better though as it can be disabled by the embedded
folk.
Pekka
next prev parent reply other threads:[~2006-01-07 2:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 15:12 [PATCH] slab: Adds missing kmalloc() checks Luiz Fernando Capitulino
2006-01-06 15:24 ` Arjan van de Ven
2006-01-06 15:30 ` Luiz Fernando Capitulino
2006-01-07 2:12 ` Pekka Enberg [this message]
2006-01-09 12:44 ` Luiz Fernando Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1136599971.7163.3.camel@localhost \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=lcapitulino@mandriva.com.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.