Re: [PATCH] [RFC] sysfs support for xen linux

[Gawain Lynch <gawain.lynch@bigpond.com>]

> diff -r c08884b412da -r cec2fc0a07c6 linux-2.6-xen-sparse/arch/xen/kernel/xen_sysfs.c
> --- /dev/null	Mon Jan  9 21:55:13 2006
> +++ b/linux-2.6-xen-sparse/arch/xen/kernel/xen_sysfs.c	Mon Jan  9 23:07:04 2006

<SNIP>

> +#ifndef BOOL
> +#define BOOL    int
> +#endif
> +
> +#ifndef FALSE
> +#define FALSE   0
> +#endif
> + 
> +#ifndef TRUE
> +#define TRUE    1
> +#endif
> + 
> +#ifndef NULL
> +#define NULL    0
> +#endif

These are already defined in kernel and a favourite nit pick on LKML.


> +struct xen_sysfs_attr
> +{
struct xen_sysfs_attr {

New line for braces are reserved for functions()

> +struct xen_sysfs_object 
> +{
struct xen_sysfs_object {

> --- /dev/null	Mon Jan  9 21:55:13 2006
> +++ b/linux-2.6-xen-sparse/include/asm-xen/xen_sysfs.h	Mon Jan  9 23:07:04 2006

<SNIP>

> +#ifndef BOOL
> +#define BOOL    int
> +#endif
> +
> +#ifndef FALSE
> +#define FALSE   0
> +#endif
> + 
> +#ifndef TRUE
> +#define TRUE    1
> +#endif
> + 
> +#ifndef NULL
> +#define NULL    0
> +#endif
> 

See above...