All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org
Subject: [PATCH] spi: remove fastcall crap
Date: Fri, 13 Jan 2006 16:46:33 -0800	[thread overview]
Message-ID: <11371995933258@kroah.com> (raw)
In-Reply-To: <11371995933448@kroah.com>

[PATCH] spi: remove fastcall crap

gcc4 generates warnings when a non-FASTCALL function pointer is assigned to a
FASTCALL one.  Perhaps it has taste.

Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
commit 5d870c8e216f121307445c71caa72e7e10a20061
tree d1d73cf5e520a10086f9a50a00fecb6041def89d
parent 7111763d391b0c5a949a4f2575aa88cd585f0ff6
author Andrew Morton <akpm@osdl.org> Wed, 11 Jan 2006 11:23:49 -0800
committer Greg Kroah-Hartman <gregkh@suse.de> Fri, 13 Jan 2006 16:29:56 -0800

 drivers/spi/spi.c       |    7 ++++++-
 include/linux/spi/spi.h |    2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index cdb242d..791c4dc 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -480,6 +480,11 @@ EXPORT_SYMBOL_GPL(spi_busnum_to_master);
 
 /*-------------------------------------------------------------------------*/
 
+static void spi_complete(void *arg)
+{
+	complete(arg);
+}
+
 /**
  * spi_sync - blocking/synchronous SPI data transfers
  * @spi: device with which data will be exchanged
@@ -508,7 +513,7 @@ int spi_sync(struct spi_device *spi, str
 	DECLARE_COMPLETION(done);
 	int status;
 
-	message->complete = (void (*)(void *)) complete;
+	message->complete = spi_complete;
 	message->context = &done;
 	status = spi_async(spi, message);
 	if (status == 0)
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index 939afd3..b05f146 100644
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -374,7 +374,7 @@ struct spi_message {
 	 */
 
 	/* completion is reported through a callback */
-	void 			FASTCALL((*complete)(void *context));
+	void 			(*complete)(void *context);
 	void			*context;
 	unsigned		actual_length;
 	int			status;


  reply	other threads:[~2006-01-14 21:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-14  0:44 [GIT PATCH] SPI patches for 2.6.15 Greg KH
2006-01-14  0:46 ` [PATCH] spi: mtd dataflash driver Greg KH
2006-01-14  0:46   ` [PATCH] spi: simple SPI framework Greg KH
2006-01-14  0:46     ` [PATCH] spi: add spi_driver to " Greg KH
2006-01-14  0:46       ` [PATCH] spi: ads7846 driver Greg KH
2006-01-14  0:46         ` [PATCH] SPI core tweaks, bugfix Greg KH
2006-01-14  0:46           ` [PATCH] spi: ads7836 uses spi_driver Greg KH
2006-01-14  0:46             ` [PATCH] spi: M25 series SPI flash Greg KH
2006-01-14  0:46               ` [PATCH] spi: add spi_bitbang driver Greg KH
2006-01-14  0:46                 ` [PATCH] SPI: add spi_butterfly driver Greg KH
2006-01-14  0:46                   ` Greg KH [this message]
2006-01-14  0:46                     ` [PATCH] spi: misc fixes Greg KH
2006-01-14  0:46                       ` [PATCH] spi: use linked lists rather than an array Greg KH
2006-01-14  4:48 ` [GIT PATCH] SPI patches for 2.6.15 Kalin KOZHUHAROV
2006-01-14 11:20   ` Kay Sievers
2006-01-14 23:56     ` Kalin KOZHUHAROV
     [not found]     ` <fa.fl6o99l.132m0gn@ifi.uio.no>
2006-01-15 14:27       ` Kai Henningsen
2006-01-16  2:30         ` Kalin KOZHUHAROV

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11371995933258@kroah.com \
    --to=gregkh@suse.de \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.