From: Tejun Heo <htejun@gmail.com>
To: axboe@suse.de, linux-kernel@vger.kernel.org
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 1/2] block: request_queue->ordcolor must not be flipped on SOFTBARRIER
Date: Mon, 16 Jan 2006 16:29:44 +0900 [thread overview]
Message-ID: <11373965843398-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <1137396584971-git-send-email-htejun@gmail.com>
q->ordcolor must not be flipped on SOFTBARRIER.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
block/elevator.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
56261a6b475696b0ff97a3df6c8fbcec9760b514
diff --git a/block/elevator.c b/block/elevator.c
index f905e47..4c0fe1c 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -336,7 +336,8 @@ void __elv_add_request(request_queue_t *
/*
* toggle ordered color
*/
- q->ordcolor ^= 1;
+ if (blk_barrier_rq(rq))
+ q->ordcolor ^= 1;
/*
* barriers implicitly indicate back insertion
--
1.0.6
next parent reply other threads:[~2006-01-16 7:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1137396584971-git-send-email-htejun@gmail.com>
2006-01-16 7:29 ` Tejun Heo [this message]
2006-01-16 7:29 ` [PATCH 2/2] block: implement elv_insert and use it (fix ordcolor flipping bug) Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11373965843398-git-send-email-htejun@gmail.com \
--to=htejun@gmail.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.