From: Johannes Berg <johannes@sipsolutions.net>
To: Oliver Neukum <oliver@neukum.org>
Cc: linux-usb-devel@lists.sourceforge.net, marcel@holtmann.org,
maxk@qualcomm.com, linux-kernel@vger.kernel.org,
bluez-devel@lists.sourceforge.net
Subject: Re: [PATCH] hci_usb: implement suspend/resume
Date: Wed, 18 Jan 2006 15:13:41 +0100 [thread overview]
Message-ID: <1137593621.4543.22.camel@localhost> (raw)
In-Reply-To: <200601181425.35524.oliver@neukum.org>
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
On Wed, 2006-01-18 at 14:25 +0100, Oliver Neukum wrote:
> This patch is wrong. usb_kill_urb() will sleep. You must not use it under
> a spinlock.
Whoops. Good catch. I'll have to analyse the logic with the lists being
used here (and probably add a temporary list). Will try to get a new
patch until tomorrow.
[side note: how about adding might_sleep() to usb_kill_urb? Then I'd at
least have noticed this right away]
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2006-01-18 14:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 23:21 [PATCH] hci_usb: implement suspend/resume Johannes Berg
2006-01-18 13:13 ` [Bluez-devel] " Marcel Holtmann
2006-01-18 13:13 ` Marcel Holtmann
2006-01-18 16:38 ` Johannes Berg
2006-02-09 1:08 ` [Bluez-devel] " John McCabe-Dansted
2006-03-21 9:42 ` Johannes Berg
2006-03-21 9:52 ` [Bluez-devel] " Marcel Holtmann
2006-03-21 9:52 ` Marcel Holtmann
2006-04-16 14:42 ` Johannes Berg
2006-01-18 13:25 ` Oliver Neukum
2006-01-18 14:13 ` Johannes Berg [this message]
2006-01-18 15:34 ` Oliver Neukum
2006-01-18 20:46 ` [linux-usb-devel] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137593621.4543.22.camel@localhost \
--to=johannes@sipsolutions.net \
--cc=bluez-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=marcel@holtmann.org \
--cc=maxk@qualcomm.com \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.