From: Stelian Pop <stelian@popies.net>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH] sound/ppc/pmac.c typo.
Date: Fri, 20 Jan 2006 11:35:38 +0100 [thread overview]
Message-ID: <1137753338.5050.8.camel@localhost.localdomain> (raw)
In 2.6.16-rc1 there is a small typo introduced by the 'Remove device_node addrs/n_addr' changes
which prevents my Powerbook G4 sound from working:
Advanced Linux Sound Architecture Driver Version 1.0.11rc2 (Wed Jan 04 08:57:20 2006 UTC).
snd: can't request rsrc 0 (Sound Control: 0x80000000:80004fff)
ALSA device list:
No soundcards found.
The patch below fixes it. Of course, the patch fixing the i2c issues
('i2c_smbus_write_i2c_block_data' patch) needs to be applied to in order for
the sound to completly work.
Signed-off-by: Stelian Pop <stelian@popies.net>
diff -r ad1abd4058ea sound/ppc/pmac.c
--- a/sound/ppc/pmac.c Fri Jan 20 11:02:26 2006 +0100
+++ b/sound/ppc/pmac.c Fri Jan 20 11:13:55 2006 +0100
@@ -1217,7 +1217,7 @@
goto __error;
}
for (i = 0; i < 3; i ++) {
- if (of_address_to_resource(np->parent, i,
+ if (of_address_to_resource(np, i,
&chip->rsrc[i])) {
printk(KERN_ERR "snd: can't translate rsrc "
" %d (%s)\n", i, rnames[i]);
--
Stelian Pop <stelian@popies.net>
next reply other threads:[~2006-01-20 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 10:35 Stelian Pop [this message]
2006-01-20 14:51 ` [PATCH] sound/ppc/pmac.c typo Takashi Iwai
2006-01-20 15:54 ` Stelian Pop
2006-01-20 16:06 ` Takashi Iwai
2006-01-20 16:09 ` Stelian Pop
2006-01-20 16:25 ` Takashi Iwai
2006-01-20 16:37 ` Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137753338.5050.8.camel@localhost.localdomain \
--to=stelian@popies.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.