All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Paul Fulghum <paulkf@microgate.com>
Cc: Diego Calleja <diegocg@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: pppd oopses current linu's git tree on disconnect
Date: Wed, 25 Jan 2006 00:22:53 +0000	[thread overview]
Message-ID: <1138148573.21723.3.camel@localhost.localdomain> (raw)
In-Reply-To: <43D6BBCF.7090403@microgate.com>

On Maw, 2006-01-24 at 17:44 -0600, Paul Fulghum wrote:
> But if space == 0 then tty->buf.tail could be NULL
> Touching tb could oops. I think you already do a similar
> check in tty_insert_flip_string() etc.

Might be worth using unlikely() hints there. I'd not considered the NULL
case.


  reply	other threads:[~2006-01-25  0:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-19  0:06 pppd oopses current linu's git tree on disconnect Diego Calleja
2006-01-19 17:33 ` Paul Fulghum
2006-01-19 22:07   ` Diego Calleja
2006-01-19 22:39     ` Paul Fulghum
2006-01-23  2:42       ` Diego Calleja
2006-01-24  3:48         ` Diego Calleja
2006-01-24 22:06           ` Paul Fulghum
2006-01-24 23:25             ` Alan Cox
2006-01-24 23:44               ` Paul Fulghum
2006-01-25  0:22                 ` Alan Cox [this message]
2006-01-25 21:00                   ` Paul Fulghum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1138148573.21723.3.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=diegocg@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulkf@microgate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.