From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: patchwork-bot+netdevbpf@kernel.org
Cc: edward.cree@amd.com, linux-net-drivers@amd.com,
davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
pabeni@redhat.com, ecree.xilinx@gmail.com,
netdev@vger.kernel.org, habetsm.xilinx@gmail.com
Subject: Re: [PATCH net] sfc: check for zero length in EF10 RX prefix
Date: Fri, 01 Sep 2023 13:28:27 -0700 [thread overview]
Message-ID: <11386.1693600107@famine> (raw)
In-Reply-To: <169355282650.26042.12939448647833622026.git-patchwork-notify@kernel.org>
patchwork-bot+netdevbpf@kernel.org wrote:
>Hello:
>
>This patch was applied to netdev/net.git (main)
>by David S. Miller <davem@davemloft.net>:
>
>On Thu, 31 Aug 2023 17:58:11 +0100 you wrote:
>> From: Edward Cree <ecree.xilinx@gmail.com>
>>
>> When EF10 RXDP firmware is operating in cut-through mode, packet length
>> is not known at the time the RX prefix is generated, so it is left as
>> zero and RX event merging is inhibited to ensure that the length is
>> available in the RX event. However, it has been found that in certain
>> circumstances the RX events for these packets still get merged,
>> meaning the driver cannot read the length from the RX event, and tries
>> to use the length from the prefix.
>> The resulting zero-length SKBs cause crashes in GRO since commit
>> 1d11fa696733 ("net-gro: remove GRO_DROP"), so add a check to the driver
>> to detect these zero-length RX events and discard the packet.
>>
>> [...]
Should this have included
Fixes: 1d11fa696733 ("net-gro: remove GRO_DROP")
to queue the patch for -stable? We have users running into this
issue on 5.15 series kernels.
-J
---
-Jay Vosburgh, jay.vosburgh@canonical.com
next prev parent reply other threads:[~2023-09-01 20:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 16:58 [PATCH net] sfc: check for zero length in EF10 RX prefix edward.cree
2023-08-31 17:07 ` Eric Dumazet
2023-09-01 7:20 ` patchwork-bot+netdevbpf
2023-09-01 20:28 ` Jay Vosburgh [this message]
2023-09-04 8:41 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11386.1693600107@famine \
--to=jay.vosburgh@canonical.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patchwork-bot+netdevbpf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.