All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@hp.com>
To: sos22@cam.ac.uk
Cc: xen-devel@lists.xensource.com, xen-ia64-devel@lists.xensource.com
Subject: cset 8690 blk driver regression
Date: Mon, 30 Jan 2006 14:08:23 -0700	[thread overview]
Message-ID: <1138655304.13596.24.camel@localhost> (raw)

Hi Steven,

  I'm seeing a regression on ia64 with this chunk of cset 8690:

--- a/xen/common/grant_table.c	Fri Jan 27 20:38:55 2006
+++ b/xen/common/grant_table.c	Fri Jan 27 20:57:07 2006
@@ -522,9 +522,7 @@
         ASSERT(d->grant_table != NULL);
         (void)put_user(GNTST_okay, &uop->status);
         for ( i = 0; i < op.nr_frames; i++ ) {
-            mfn = gnttab_shared_mfn(d, d->grant_table, i);
-            if (shadow_mode_translate(d))
-                mfn = __mfn_to_gpfn(d, mfn);
+            mfn = __mfn_to_gpfn(d, gnttab_shared_mfn(d, d->grant_table, i));
             (void)put_user(mfn, &op.frame_list[i]);
         }
     }

With this chunk, my domU no longer finds it's block device and fails to
boot:

VFS: Cannot open root device "hda1" or unknown-block(0,0)
Please append a correct "root=" boot option
Kernel panic - not syncing: VFS: Unable to mount root fs on
unknown-block(0,0)

Everything appears fine if I revert it.  Is this an intentional change?
It appears to be more of a functional change than the check-in comment
for this changeset would imply.  Thanks,

	Alex

-- 
Alex Williamson                             HP Linux & Open Source Lab

             reply	other threads:[~2006-01-30 21:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-30 21:08 Alex Williamson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-01-31 20:11 [Xen-ia64-devel] cset 8690 blk driver regression Magenheimer, Dan (HP Labs Fort Collins)
2006-01-31 22:32 ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1138655304.13596.24.camel@localhost \
    --to=alex.williamson@hp.com \
    --cc=sos22@cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    --cc=xen-ia64-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.