Re: [PATCH 6/11] LED: Add LED device support for the zaurus corgi and spitz models

[Richard Purdie <rpurdie@rpsys.net>]

On Tue, 2006-01-31 at 21:54 -0800, Greg KH wrote:
> On Tue, Jan 31, 2006 at 01:41:43PM +0000, Richard Purdie wrote:
> > Adds LED drivers for LEDs found on the Sharp Zaurus c7x0 (corgi, 
> > shepherd, husky) and cxx00 (akita, spitz, borzoi) models.
> > 
> > Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
> > 
> > Index: linux-2.6.15/arch/arm/mach-pxa/corgi.c
> > ===================================================================
> > --- linux-2.6.15.orig/arch/arm/mach-pxa/corgi.c	2006-01-29 16:02:30.000000000 +0000
> > +++ linux-2.6.15/arch/arm/mach-pxa/corgi.c	2006-01-29 16:11:47.000000000 +0000
> > @@ -165,6 +165,15 @@
> >  
> >  
> >  /*
> > + * Corgi LEDs
> > + */
> > +static struct platform_device corgiled_device = {
> > +	.name		= "corgi-led",
> > +	.id		= -1,
> > +};
> 
> Please use the platform device interface to create these dynamically and
> don't make static structures.

This is very much in keeping with the rest of that file and the way this
has been traditionally been handled in arm board support files.
Admittedly, definitions are usually more complex than this.

Russell, do you have a view on this?

Richard