All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] dund needs pppd
Date: Tue, 07 Feb 2006 12:18:38 +0100	[thread overview]
Message-ID: <1139311118.15160.19.camel@localhost> (raw)
In-Reply-To: <52492.192.168.0.2.1138486931.squirrel@jcr.homelinux.com>

Hi Jean-Claude,

> May be it is an evidence for a bluetooth developper, but, as a beginner in
> the bluetooth area,  I spend a lot of time trying to establish a
> connection with a bluetooth device before I looked at the source code of
> dund and realized it needed pppd installed on the computer.
> 
> dund reports no error message !
> 
> I think it should be nice for future users to add an error message like
> that :
> 
> diff -ru bluez-utils-2.19.orig/dund/dun.c bluez-utils-2.19/dund/dun.c
> --- bluez-utils-2.19.orig/dund/dun.c    2006-01-28 22:33:47.000000000 +0100
> +++ bluez-utils-2.19/dund/dun.c 2006-01-28 22:31:10.000000000 +0100
> @@ -175,6 +175,7 @@
>                 close(fd);
> 
>         execvp(prog, args);
> +        syslog(LOG_INFO, "Error while executing %s\n", prog);
>         exit(1);
>  }

good catch, but your patch has some problems. It should be LOG_ERR
instead of LOG_INFO and you don't need a "\n" at the end when calling
syslog(). However this is fixed in the CVS now.

Regards

Marcel




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  reply	other threads:[~2006-02-07 11:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-28 22:22 [Bluez-devel] dund needs pppd Jean-Claude Repetto
2006-02-07 11:18 ` Marcel Holtmann [this message]
2006-02-07 11:47   ` Jean-Claude Repetto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1139311118.15160.19.camel@localhost \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.