All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darren Jenkins\\" <darrenrjenkins@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [kj][Patch] remove implicit sign bit on single bit
Date: Wed, 08 Feb 2006 04:17:27 +0000	[thread overview]
Message-ID: <1139372248.9409.15.camel@localhost.localdomain> (raw)

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

Hi,

This is my first patch so I hope I get everything right.

http://linuxicc.sourceforge.net/

Warnings/Error while compiling with Intel C Compiler

Says there is a Warning #108: implictly-signed bit field of length 1

in sound/oss/viacXXX_audio.c @ line number 310

looking at the code it seems like it is supposed to be a single bit
field used as a lock. This just makes it unsigned.

Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>


--- linux-2.6.16-rc2/sound/oss/via82cxxx_audio.c.orig	2006-02-08
13:43:27.000000000 +1100
+++ linux-2.6.16-rc2/sound/oss/via82cxxx_audio.c	2006-02-08
13:45:39.000000000 +1100
@@ -306,9 +306,8 @@ struct via_info {
 	unsigned intmask: 1;	/* Needs int bits */
 	unsigned sixchannel: 1;	/* 8233/35 with 6 channel support */
 	unsigned volume: 1;
+	unsigned locked_rate : 1;
 
-	int locked_rate : 1;
-	
 	int mixer_vol;		/* 8233/35 volume  - not yet implemented */
 
 	struct semaphore syscall_sem;






[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2006-02-08  4:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-08  4:17 Darren Jenkins\ [this message]
2006-02-08  4:39 ` [kj][Patch] remove implicit sign bit on single bit Nishanth Aravamudan
2006-02-08  4:39 ` Randy.Dunlap
2006-02-08 22:52 ` Alexey Dobriyan
2006-02-09  0:33 ` Greg KH
2006-02-09  7:15 ` Nishanth Aravamudan
2006-02-09 10:21 ` Darren Jenkins\
2006-02-20 21:34 ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1139372248.9409.15.camel@localhost.localdomain \
    --to=darrenrjenkins@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.