From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Date: Sun, 12 Feb 2006 01:07:44 +0000 Subject: Re: [PATCH] sparc32: Fix div, udiv, mul, umul, rem, urem breakage Message-Id: <1139706464.22363.120.camel@localhost.localdomain> List-Id: References: <20060211113817.GA25564@palantir8> In-Reply-To: <20060211113817.GA25564@palantir8> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: sparclinux@vger.kernel.org On Sun, 2006-02-12 at 00:21 +0000, Al Viro wrote: > On Sun, Feb 12, 2006 at 10:54:37AM +1100, Rusty Russell wrote: > > It seems so, as Al so comprehensively explained. It was binutils > > breakage. You might find something like this (note: untested!) > > preferable. Other archs may well want EXPORT_SYMBOL_AS for special > > effects anyway. > > > > Signed-off-by: Rusty Russell > > > > Make sparc use the same "remove the dot" mangling as other archs, which > > depmod already understands. Avoid namespace pollution (not really a > > problem, but ugly) by using an __export_ alias: it needs to be a global > > symbol as attempts to craft an alias in the sparc_ksyms.c was rejected > > by various recent binutils versions: > > ewww... > > You do realize that your "remove the dot" is ppc-only? I.e. just as much > of a special case as sparc-only mapping. No Al. Since day 1 we've had this in module-init-tools. It was used by both PPC and Sparc. Sparc stopped using it to work around sparc-specific binutils bugs. I'm naturally resistent to (more) arch-specific hacks in depmod. In the kernel, arch-specifics get testing, in module-init-tools they don't. > Seriously, fix in depmod is considerably smaller that what you've just > posted, not to mention being conceptually simpler. You're exactly right. By this logic, I look forward to you fixing binutils. Glad we resolved that! Rusty. -- ccontrol: http://ozlabs.org/~rusty/ccontrol