Re: [KJ] kzalloc() conversion in drivers/isdn

[Eric Sesterhenn <snakebyte@gmx.de>]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

On Tue, 2006-02-28 at 22:32 +0300, Alexey Dobriyan wrote:
> >      /* Allocate space for private device-specific data */
> > -    local = kmalloc(sizeof(local_info_t), GFP_KERNEL);
> > -    if (!local) return -ENOMEM;
> > -    memset(local, 0, sizeof(local_info_t));
> > +    local = kzalloc(sizeof(local_info_t), GFP_KERNEL);
> > +    if (!local)
> > +	return -ENOMEM;
> 
> Don't even try to sneak in unrelated changes. I mean, really. Why bother
> if I'll carefully drop them anyway?

I thought one should clean up the code while doing this
stuff? Or should coding style cleanups just be done in the exact
line one is changing? What would be the way to fix such thing?
Send a patch which indents and cleans the entire file, which would
possible break other patches in queue for that file. or send a patch
to clean up all if() foo; constructs in a subsystem?
Sorry to have caused you work overhead, i'll try not to do those
cleanups anymore.

Thanks Eric


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors