All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darren Jenkins\\" <darrenrjenkins@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ][Patch] remove request_region from matroxfb_base.c
Date: Mon, 06 Mar 2006 11:57:27 +0000	[thread overview]
Message-ID: <1141646248.8201.15.camel@localhost.localdomain> (raw)

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

G'day list

matroxfb_base.c calles request_region() without checking it's return
value @ 1737.
After getting advice from Petr Vandrovec it seems that this memory
region isn't actually used in matroxfb_base.c, it was just reserved to
stop vesafb and matrox being loaded on the same head. After looking at
vesafb.c is seems that this doesn't work, as vesafb doesn't check the
return value of request_region either.
So the patch below removes the request_region call because it doesn't
actually do anything anymore.

Thanks again for your explanation Petr.

Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>

--- linux-2.6.16-rc5/drivers/video/matrox/matroxfb_base.c.orig	2006-03-06 21:36:54.000000000 +1100
+++ linux-2.6.16-rc5/drivers/video/matrox/matroxfb_base.c	2006-03-06 22:42:17.000000000 +1100
@@ -1733,8 +1733,6 @@ static int initMatrox2(WPMINFO struct bo
 	}
 #endif	/* CONFIG_MTRR */
 
-	if (!ACCESS_FBINFO(devflags.novga))
-		request_region(0x3C0, 32, "matrox");
 	matroxfb_g450_connect(PMINFO2);
 	ACCESS_FBINFO(hw_switch->reset(PMINFO2));
 



[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

                 reply	other threads:[~2006-03-06 11:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1141646248.8201.15.camel@localhost.localdomain \
    --to=darrenrjenkins@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.