From: "Bryan O'Sullivan" <bos@pathscale.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: rolandd@cisco.com, gregkh@suse.de, akpm@osdl.org,
davem@davemloft.net, linux-kernel@vger.kernel.org,
openib-general@openib.org
Subject: Re: [PATCH 4 of 20] ipath - support for HyperTransport devices
Date: Thu, 09 Mar 2006 15:21:41 -0800 [thread overview]
Message-ID: <1141946501.10693.32.camel@serpentine.pathscale.com> (raw)
In-Reply-To: <ada3bhrgr36.fsf@cisco.com>
On Thu, 2006-03-09 at 15:01 -0800, Roland Dreier wrote:
> It seems like all these hypertransport magic constants should be in a
> general .h somewhere. I'm not sure if it makes sense to put them in
> <linux/pci.h>, or start a <linux/hypertransport.h>.
Either way is fine by me.
> The logic here is pretty hard to follow, and you're getting squeezed
> pretty hard by indenting 5 tabs stops. Can ipath_setup_ht_config() be
> split up into subfunctions?
Definitely. I mentioned this in the introductory message for the series
as something I'm working on.
<b
next prev parent reply other threads:[~2006-03-09 23:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0b1b4f4c093e2db6153e.1141922817@localhost.localdomain>
2006-03-09 23:01 ` [PATCH 4 of 20] ipath - support for HyperTransport devices Roland Dreier
2006-03-09 23:21 ` Bryan O'Sullivan [this message]
2006-03-10 0:35 [PATCH 0 of 20] [RFC] ipath driver - another round for review Bryan O'Sullivan
2006-03-10 0:35 ` [PATCH 4 of 20] ipath - support for HyperTransport devices Bryan O'Sullivan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1141946501.10693.32.camel@serpentine.pathscale.com \
--to=bos@pathscale.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rdreier@cisco.com \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.