From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Revell Subject: Re: Dreamcast AICA driver Date: Sun, 12 Mar 2006 01:28:21 -0500 Message-ID: <1142144901.25358.108.camel@mindpipe> References: <1142124747.9496.50.camel@localhost.localdomain> <1142125920.25358.22.camel@mindpipe> <1142126427.9496.56.camel@localhost.localdomain> <1142144081.25358.103.camel@mindpipe> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from viper.oldcity.dca.net (viper.oldcity.dca.net [216.158.38.4]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with SMTP id 815941DF for ; Sun, 12 Mar 2006 07:28:23 +0100 (MET) In-Reply-To: <1142144081.25358.103.camel@mindpipe> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Adrian McMenamin Cc: linux-sh , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Sun, 2006-03-12 at 01:14 -0500, Lee Revell wrote: > You should submit this to ALSA now, as a patch against CVS... static int snd_aicapcm_free(snd_card_aica_t *dreamcastcard) { release_mem_region(0xa0702c00, 0x4); release_mem_region(0xa0800000, 0x200000); return 0; } Actually this driver still has way too many magic numbers - if you're not exactly sure what a constant does then document it with comments in the header file. It looks like many of these will be trivial to document: if (request_mem_region(0xa0702c00, 4, "AICA ARM control")== NULL) return -ENOMEM; if (request_mem_region(0xa0800000, 0x200000, "AICA Sound RAM") == NULL) Lee ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642