All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: Nathan Lynch <nathanl@austin.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/7] powerpc numa: Minor debugging code changes
Date: Tue, 21 Mar 2006 10:27:11 -0800	[thread overview]
Message-ID: <1142965632.10906.163.camel@localhost.localdomain> (raw)
In-Reply-To: <11429012851755-git-send-email-nathanl@austin.ibm.com>

On Mon, 2006-03-20 at 18:34 -0600, Nathan Lynch wrote:
> Don't print a meaningless associativity depth (-1) on non-numa systems.
...
> -	dbg("NUMA associativity depth for CPU/Memory: %d\n", min_common_depth);
>  	if (min_common_depth < 0)
>  		return min_common_depth;
>  
> +	dbg("NUMA associativity depth for CPU/Memory: %d\n", min_common_depth);

This is debugging code anyway, right?

I thought this might be useful when you're booting on a machine which
you _think_ should be NUMA, but doesn't come up that way.  Did you boot
a non-NUMA kernel, or is something in the reporting wrong?  It makes it
pretty obvious when you see this printout.  

-- Dave

  reply	other threads:[~2006-03-21 19:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-21  0:33 [PATCH 0/7] powerpc numa updates and fixes Nathan Lynch
2006-03-21  0:34 ` [PATCH 1/7] powerpc numa: fix boot_cpuid always assigned to node 0 Nathan Lynch
2006-03-21  0:34 ` [PATCH 2/7] powerpc numa: Minor debugging code changes Nathan Lynch
2006-03-21 18:27   ` Dave Hansen [this message]
2006-03-21 18:54     ` Nathan Lynch
2006-03-21  0:35 ` [PATCH 3/7] powerpc numa: Minor cpu hotplug-related cleanups Nathan Lynch
2006-03-21  0:35 ` [PATCH 4/7] powerpc numa: Get rid of "numa domain" terminology Nathan Lynch
2006-03-21  0:36 ` [PATCH 5/7] powerpc numa: Consolidate handling of Power4 special case Nathan Lynch
2006-03-21  3:54   ` Jon Mason
2006-03-21  0:36 ` [PATCH 6/7] powerpc numa: Support sparse online node map Nathan Lynch
2006-03-21  0:37 ` [PATCH 7/7] powerpc numa: Consolidate assignment of cpus to nodes Nathan Lynch
2006-03-21 18:38   ` Dave Hansen
2006-03-21 19:16     ` Nathan Lynch
2006-03-21 23:09       ` Michael Ellerman
2006-03-21 23:22         ` Nathan Lynch
2006-03-21 23:34           ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1142965632.10906.163.camel@localhost.localdomain \
    --to=haveblue@us.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=nathanl@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.